Skip to content

syncpack updated to v14 #7844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

syncpack updated to v14 #7844

wants to merge 1 commit into from

Conversation

sreeisalso
Copy link
Contributor

What is it?

  • Feature / enhancement

Description

refer to PR #7587 for previous discussion

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2025

⚠️ No Changeset found

Latest commit: e30165f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sreeisalso sreeisalso mentioned this pull request Aug 20, 2025
Closed
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview e30165f

@sreeisalso sreeisalso marked this pull request as ready for review August 21, 2025 07:11
@sreeisalso sreeisalso requested a review from a team as a code owner August 21, 2025 07:11
wmertens
wmertens reviewed Aug 21, 2025
View reviewed changes
package.json
@@ -155,7 +84,7 @@
"snoop": "1.0.4",
"source-map": "0.7.4",
"svgo": "3.3.2",
"syncpack": "12.3.3",
"syncpack": "14.0.0-alpha.19",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we really be depending on an alpha version here? Is there something broken that needs this version to fix?

gioboa
gioboa reviewed Sep 2, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR still valid?

@gioboa gioboa added the STATUS-2: missing info Incomplete issue/pr template or missing important information label Sep 2, 2025
@sreeisalso
Copy link
Contributor Author

Will look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens left review comments

@gioboa gioboa gioboa left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
STATUS-2: missing info Incomplete issue/pr template or missing important information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreeisalso @wmertens @gioboa